Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade binding to fix bug #30742

Merged
merged 4 commits into from
May 2, 2024
Merged

Upgrade binding to fix bug #30742

merged 4 commits into from
May 2, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 28, 2024

Fix #30518

@lunny lunny added the type/bug label Apr 28, 2024
@lunny lunny added this to the 1.21.12 milestone Apr 28, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2024
@lunny lunny requested a review from techknowlogick April 28, 2024 06:47
@delvh
Copy link
Member

delvh commented Apr 28, 2024

Error: Not equal:
expected: 201
actual : 500
Test: TestAPICreateAndDeleteUser
Messages: Request: POST /api/v1/admin/users?token=f666b394cc0438ee3394d60d55a3d5a69a75b0ab

Sounds related

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2024
techknowlogick
techknowlogick previously requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci Fail related

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 30, 2024 •
edited
Loading

Same to another PR #29674, waiting for https://gitea.com/go-chi/binding/pulls/17
Sorry for the incompletely fix.

@lunny
Copy link
Member Author

lunny commented Apr 30, 2024

Upgrade chi binding in a55c510

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Apr 30, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 30, 2024
@GiteaBot GiteaBot removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2024
@6543 6543 merged commit 87bd47c into go-gitea:release/v1.21 May 2, 2024
27 checks passed
@lunny lunny deleted the lunny/upgrade_binding branch May 2, 2024 12:58
@lunny lunny mentioned this pull request May 2, 2024
Merged
lunny added a commit that referenced this pull request May 2, 2024
@lunny
Upgrade chi-binding (#30826)
cb9e1a3 
Front port #30742
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 2, 2024
@lunny @GiteaBot
Upgrade chi-binding (go-gitea#30826)
a4e92b6 
Front port go-gitea#30742
@GiteaBot GiteaBot mentioned this pull request May 2, 2024
Merged
silverwind pushed a commit that referenced this pull request May 2, 2024
@GiteaBot @lunny
Upgrade chi-binding (#30826) (#30830)
c34a03d 
Backport #30826 by @lunny

Front port #30742

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@lunny lunny mentioned this pull request May 13, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@yp05327 yp05327 yp05327 approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.21.12
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @delvh @yp05327 @techknowlogick @6543 @GiteaBot